[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Mash Code Merge
I probably added the print message to discover when the device was
openned. You can remove it - in fact it is commented out. I vaguely
recall this code but don't remember what I did to it. Go ahead and do
what you have to fix it. You might want
to look for the VideoTap::open_device, I don't recall there being a
method with that name.
Larry
Matthew Delco wrote:
>
> I merged the code together and found that vic has a problem where pressing
> the "Transmit" button causes an abort. I finally tracked the bug down to
> the VideoTap.start() function (pasted below). The code:
>
> set err [$self open_device]
> if { $err != "" } {
> return $err
> }
>
> was changed to:
>
> return "VideoTap::start: device is not openned"
>
> If I undo the change then the code appears to work fine. This change
> doesn't look familiar to me, and I'm hoping that you might have a better
> idea of what's going on. I haven't yet reverted the code back in CVS
> (since this could possibly be an issue with my particular version of the
> code).
>
> VideoTap public start {} {
> $self instvar running_ grabber_ capwin_
> if !$running_ {
> if ![info exists grabber_] {
> set err [$self open_device]
> if { $err != "" } {
> return $err
> }
> # return "VideoTap::start: device is not openned"
> }
> if [info exists capwin_] {
> wm deiconify [winfo toplevel $capwin_]
> update idletasks
> }
> $grabber_ send 1
> set running_ 1
> }
> return ""
> }
--
Professor Lawrence A. Rowe Internet: Rowe@BMRC.Berkeley.EDU
Computer Science Division - EECS Phone: 510-642-5117
University of California, Berkeley Fax: 510-642-5615
Berkeley, CA 94720-1776 URL: http://bmrc.berkeley.edu/~larry