Re: Has anyone...

[Andrew Swan <aswan@cs.berkeley.edu>]

Matthew Delco wrote:
> > - does it make sense to cache the return value for
> >   GetDefaultMulticastInterface() ?  it looks like it
> >   does a bunch of work and like the result shouldn't
> >   change over multiple calls.
> 
> It might make sense for the value to be cached over a short interval (the
> routine gets called 8 times when vic starts).  Given that the network
> configuration can change I'm not sure if it makes sense to cache the value
> over a long period (but perhaps it's better than an application doesn't
> react to adapter changes, that way it always uses the same interface
> rather than potentially multiple ones).

right, but does it ever get called again after startup?

> > - how about putting the GetDefaultMulticastInterface()
> >   function in a separate file?  my suggested name for
> >   the file is fixes_for_broken_win32_crap.c
> 
> I don't have strong feelings either way on this point (the suggested
> filename might be too long for Windows to handle...), but if I do make the
> change then it will be next week at the earliest.

the filename was tongue-in-cheek but the suggestion was
serious...  i think isolating platform-specific routines
to their own files rather than using extensive ifdefs is
good style.

-Andrew