Re: Has anyone...

[Andrew Swan <aswan@cs.berkeley.edu>]

Matthew Delco wrote:
> Anyway, the May 10 tarball compiles for me now, thanks.  Attached is a
> copy of what I've been working on this weekend (originally in 5.2 as
> net-ip.cc, and now ported [correctly?] to udp.cc in the current code).  
> The proposed change is for Windows, and is an attempt to make a smarter
> substitute for INADDR_ANY when joining multicast groups.  This issue was
> discussed briefly on this list on Sept 5/6, 2002.  Ivan might like the
> change, although I don't know if anyone else will appreciate it.

cool -- i just have two stylistic comments:

- does it make sense to cache the return value for
  GetDefaultMulticastInterface() ?  it looks like it
  does a bunch of work and like the result shouldn't
  change over multiple calls.
- how about putting the GetDefaultMulticastInterface()
  function in a separate file?  my suggested name for
  the file is fixes_for_broken_win32_crap.c

-Andrew